linux-kernel - Re: [PATCH] rtlwifi: Change long delays to sleeps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fusssxqn.fsf@kamboji.qca.qualcomm.com>
Date:	Sat, 04 Jun 2016 19:52:00 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Jan Kiszka <jan.kiszka@....de>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	devel@...verdev.osuosl.org, linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: Change long delays to sleeps

Jan Kiszka <jan.kiszka@....de> writes:

> On 2016-02-15 23:12, Larry Finger wrote:
>> Routine rtl_addr_delay() uses delay statements in code that can
>> sleep. To improve system responsiveness, the various delay statements
>> are changed.
>> 
>> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are
>> rewritten to use the code in rtl_addr_delay() for most of their
>> input values.
>> 
>> Suggested-by: Byeoungwook Kim <quddnr145@...il.com>
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

[...]

> This breaks spectacularly when turning on a little bit of correctness
> checking:
>
> BUG: scheduling while atomic: wpa_supplicant/1116/0x00000002

This should fix it:

https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=de26859dcf363d520cc44e59f6dcaf20ebe0aadf

-- 
Kalle Valo