linux-kernel - Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160604193711.GC14480@ZenIV.linux.org.uk>
Date:	Sat, 4 Jun 2016 20:37:11 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Salah Triki <salah.triki@....org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real
 error

On Sat, Jun 04, 2016 at 07:53:19PM +0100, Salah Triki wrote:
> File not found is not an error and lookup must return error code only
> on real error, otherwise creating inodes with functions like create,
> mkdir and so on will fail.

You do realize that befs is read-only and doesn't have ->mkdir() and friends,
right?  Patch is almost correct (you want d_add(dentry, NULL) if you go
that way, or you'll be calling ->lookup() ever time anyway), but it doesn't
make much sense on its own.