linux-kernel - Re: [PATCH v3 1/2] b43: Remove unused phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575346CF.9040003@lwfinger.net>
Date:	Sat, 4 Jun 2016 16:23:27 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Guenter Roeck <linux@...ck-us.net>,
	Kalle Valo <kvalo@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	b43-dev@...ts.infradead.org, netdev@...r.kernel.org, m@...s.ch
Subject: Re: [PATCH v3 1/2] b43: Remove unused phy_a code

On 06/04/2016 09:54 AM, Guenter Roeck wrote:
> gcc-6 reports the following error with -Werror=unused-const-variable.
>
> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> 	'b43_phyops_a' defined but not used
>
> Per Michael Büsch: "All a-phy code is usused", so remove it all,
> and move the remaining Type-G initialization code into phy_g.c.
>
> Reported-by: Fengguang Wu <fengguang.wu@...el.com> [0-day test robot]
> Cc: Michael Büsch <m@...s.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v3: Do not rename b43_phy_inita()
> v2: Remove phy_a.c; move left-over code into phy_g.c
>      Remove now unused data structure

These two patches have been tested on a BCM4318.

Larry