linux-kernel - Re: [PATCHv2 1/4] usb: gadget: fix unused-but-set-variale warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201606050703.5tW1DAmU%fengguang.wu@intel.com>
Date:	Sun, 5 Jun 2016 07:24:11 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	kbuild-all@...org, Felipe Balbi <felipe.balbi@...ux.intel.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michal Nazarewicz <mina86@...a86.com>
Subject: Re: [PATCHv2 1/4] usb: gadget: fix unused-but-set-variale warnings

Hi,

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.7-rc1 next-20160603]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michal-Nazarewicz/usb-gadget-fix-unused-but-set-variale-warnings/20160531-202120
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-h0-06050347 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/linux/seqlock.h:35:0,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from drivers/usb/gadget/udc/pch_udc.c:10:
   drivers/usb/gadget/udc/pch_udc.c: In function 'pch_udc_pcd_ep_disable':
>> drivers/usb/gadget/udc/pch_udc.c:1733:21: error: 'dev' undeclared (first use in this function)
     spin_lock_irqsave(&dev->lock, iflags);
                        ^
   include/linux/spinlock.h:208:34: note: in definition of macro 'raw_spin_lock_irqsave'
      flags = _raw_spin_lock_irqsave(lock); \
                                     ^~~~
   drivers/usb/gadget/udc/pch_udc.c:1733:2: note: in expansion of macro 'spin_lock_irqsave'
     spin_lock_irqsave(&dev->lock, iflags);
     ^~~~~~~~~~~~~~~~~
   drivers/usb/gadget/udc/pch_udc.c:1733:21: note: each undeclared identifier is reported only once for each function it appears in
     spin_lock_irqsave(&dev->lock, iflags);
                        ^
   include/linux/spinlock.h:208:34: note: in definition of macro 'raw_spin_lock_irqsave'
      flags = _raw_spin_lock_irqsave(lock); \
                                     ^~~~
   drivers/usb/gadget/udc/pch_udc.c:1733:2: note: in expansion of macro 'spin_lock_irqsave'
     spin_lock_irqsave(&dev->lock, iflags);
     ^~~~~~~~~~~~~~~~~
   drivers/usb/gadget/udc/pch_udc.c: In function 'pch_udc_alloc_request':
   drivers/usb/gadget/udc/pch_udc.c:1770:7: error: 'dev' undeclared (first use in this function)
     if (!dev->dma_addr)
          ^~~
   In file included from include/linux/seqlock.h:35:0,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from drivers/usb/gadget/udc/pch_udc.c:10:
   drivers/usb/gadget/udc/pch_udc.c: In function 'pch_udc_pcd_dequeue':
   drivers/usb/gadget/udc/pch_udc.c:1943:21: error: 'dev' undeclared (first use in this function)
     spin_lock_irqsave(&dev->lock, flags);
                        ^
   include/linux/spinlock.h:208:34: note: in definition of macro 'raw_spin_lock_irqsave'
      flags = _raw_spin_lock_irqsave(lock); \
                                     ^~~~
   drivers/usb/gadget/udc/pch_udc.c:1943:2: note: in expansion of macro 'spin_lock_irqsave'
     spin_lock_irqsave(&dev->lock, flags);
     ^~~~~~~~~~~~~~~~~
   drivers/usb/gadget/udc/pch_udc.c: In function 'pch_udc_pcd_set_halt':
   drivers/usb/gadget/udc/pch_udc.c:1979:7: error: 'dev' undeclared (first use in this function)
     if (!dev->driver || (dev->gadget.speed == USB_SPEED_UNKNOWN))
          ^~~
   drivers/usb/gadget/udc/pch_udc.c: In function 'pch_udc_pcd_set_wedge':
   drivers/usb/gadget/udc/pch_udc.c:2021:7: error: 'dev' undeclared (first use in this function)
     if (!dev->driver || (dev->gadget.speed == USB_SPEED_UNKNOWN))
          ^~~

vim +/dev +1733 drivers/usb/gadget/udc/pch_udc.c

  1727			return -EINVAL;
  1728	
  1729		ep = container_of(usbep, struct pch_udc_ep, ep);
  1730		if ((usbep->name == ep0_string) || !ep->ep.desc)
  1731			return -EINVAL;
  1732	
> 1733		spin_lock_irqsave(&dev->lock, iflags);
  1734		empty_req_queue(ep);
  1735		ep->halted = 1;
  1736		pch_udc_ep_disable(ep);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26310 bytes)