lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGRGNgV_tcM+3L7eWjWfuOEeWWo+ThWK_+GTNiGbZLL=acg8VA@mail.gmail.com>
Date:	Sat, 4 Jun 2016 20:35:46 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Hugh Sipiere <hgsipiere@...il.com>
Cc:	Michael Büsch <m@...s.ch>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Drivers: ssb: Fix bare unsigned and changed to trailing comments

Hi Hugh,

On Sat, Jun 4, 2016 at 10:39 AM, Hugh Sipiere <hgsipiere@...il.com> wrote:
> I changed drivers/ssb/driver_gpio.c to better fit the coding style.
> I changed unsigned to unsigned int
> Two comments were changed to not end on a line with the text.
>
> Signed-off-by: Hugh Sipiere <hgsipiere@...il.com>

You should separate the changes into two patches, one to change
"unsigned" to "unsigned int" and one to fix the comments.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ