linux-kernel - Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465122103.5944.0.camel@poochiereds.net>
Date:	Sun, 05 Jun 2016 06:21:43 -0400
From:	Jeff Layton <jlayton@...chiereds.net>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL
 postfix

On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote:
> On 32-bit:
> 
>     fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’:
>     fs/nfsd/blocklayout.c:337: warning: integer constant is too large for ‘long’ type
>     fs/nfsd/blocklayout.c:344: warning: integer constant is too large for ‘long’ type
>     fs/nfsd/blocklayout.c: In function ‘nfsd4_scsi_fence_client’:
>     fs/nfsd/blocklayout.c:385: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "ULL" postfix to 64-bit constant NFSD_MDS_PR_KEY to fix
> this.
> 
> Fixes: f99d4fbdae6765d0 ("nfsd: add SCSI layout support")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Christoph Hellwig <hch@....de>
> ---
> v2:
>   - Add Reviewed-by.
> 
> Despite Bruce's "Thanks, applying for 4.6.--b." on 2016-03-29, this
> still hasn't made it into next-20160603.
> ---
>  fs/nfsd/blocklayout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
> index e55b5242614da7a9..31f3df193bdbb47b 100644
> --- a/fs/nfsd/blocklayout.c
> +++ b/fs/nfsd/blocklayout.c
> @@ -290,7 +290,7 @@ out_free_buf:
>  	return error;
>  }
>  
> -#define NFSD_MDS_PR_KEY		0x0100000000000000
> +#define NFSD_MDS_PR_KEY		0x0100000000000000ULL
>  
>  /*
>   * We use the client ID as a unique key for the reservations.

Thanks!

Reviewed-by: Jeff Layton <jlayton@...chiereds.net>