linux-kernel - Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575453FA.6090604@lwfinger.net>
Date:	Sun, 5 Jun 2016 11:31:54 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Binoy Jayan <binoy.jayan@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jakub Sitnicki <jsitnicki@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with
 completion

On 06/03/2016 04:59 AM, Binoy Jayan wrote:
> The semaphore 'cmd_queue_sema' is used as completion,
> so convert it to struct completion.
>
> Signed-off-by: Binoy Jayan <binoy.jayan@...aro.org>

The subject for this patch has a misplaced "i" at the beginning courtesy of vi.

One other point, it is customary to start the patch subject with "staging: 
rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than 
rtl8188eu as the former is the actual name of the driver, but either will work.

I have tested all 4 of these patches with no problems, thus

Acked-by: Larry Finger <Larry.Finger@...inger.net>

As you may have noted, my testing of the modified driver has resulted in some 
additional fixes for various problems including a system panic caused by an 
ill-advised and untested change.

Larry