linux-kernel - Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2016 11:24:56 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	George Spelvin <linux@...encehorizons.net>
Cc:	bjorn@...k.no, linux-kernel@...r.kernel.org,
	matt@...eblueprint.co.uk, rv@...musvillemoes.dk
Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value
 warning

On Sun, 2016-06-05 at 15:25 -0400, George Spelvin wrote:
> From andriy.shevchenko@...ux.intel.com Sun Jun 05 14:19:48 2016
> X-ExtLoop1: 1
> X-IronPort-AV: E=Sophos;i="5.26,421,1459839600"; 
>    d="scan'208";a="995605979"
> Subject: Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return
> value
>  warning
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> To: George Spelvin <linux@...encehorizons.net>
> Cc: bjorn@...k.no, linux-kernel@...r.kernel.org, matt@...eblueprint.co
> .uk, 
> 	rv@...musvillemoes.dk
> Date: Sun, 05 Jun 2016 17:21:04 +0300
> In-Reply-To: <20160604131622.28377.qmail@...sciencehorizons.net>
> References: <20160604131622.28377.qmail@...sciencehorizons.net>
> Organization: Intel Finland Oy
> Content-Type: text/plain; charset="UTF-8"
> X-Mailer: Evolution 3.20.2-2 
> Mime-Version: 1.0
> Content-Transfer-Encoding: 8bit

^^^^ Something wrong with mail configuration?

> 
> Andy Shevchenko worte:
> > On Sat, 2016-06-04 at 09:16 -0400, George Spelvin wrote:
> > Which I against of. Please, use normal hex_to_bin() calls here.
> > 
> > Compiler will inline it anyway, but at least will not do second
> > check
> > for nothing.
> 
> Um... huh?  Neither hex_to_bin() nor hex2bin() are inline functions.
> They're declared as extern in <linux/kernel.h> and defined in
> lib/hexdump.c.
> 
> One call is smaller than two calls, which is why I did that.
> 
> It's also faster, as hex_to_bin() *is* inlined within hex2bin()
> (if you compile with -O).

To be sure it faster we need the measurements. Sometimes it's not
obvious.

> 
> Is your request based on a false premise?

Yeah, you are right, I looked at hex2bin() which is in the same module.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy