linux-kernel - Re: [PATCH 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160605.231102.1130873370221997319.davem@davemloft.net>
Date:	Sun, 05 Jun 2016 23:11:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thloh@...era.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	peppe.cavallaro@...com, dinguyen@...era.com, thloh85@...il.com,
	cnphoon@...era.com, phooncn@...il.com
Subject: Re: [PATCH 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: <thloh@...era.com>
Date: Fri, 3 Jun 2016 02:07:15 -0700

> From: Tien Hock Loh <thloh@...era.com>
> 
> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> the dwmac is set to sgmii
> 
> Signed-off-by: Tien Hock Loh <thloh@...era.com>

Please at least make an effort to use consistent coding style.

You rework this function to do this:

> -	if (!splitter_base)
> -		return;
> +	if (splitter_base) {

And then you add something like this:

> +	if ((tse_pcs_base) && (sgmii_adapter_base)) {
> +		tse_pcs_fix_mac_speed(&dwmac->pcs, phy_dev, speed);
> +	}

Excessive parenthesis in the if() condition, and single statement
basic blocks do not get curly braces.