[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 15:31:21 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: js1304@...il.com, Andrew Morton <akpm@...ux-foundation.org>
Cc: mgorman@...hsingularity.net, Minchan Kim <minchan@...nel.org>,
Alexander Potapenko <glider@...gle.com>,
Hugh Dickins <hughd@...gle.com>,
Michal Hocko <mhocko@...nel.org>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v2 3/7] mm/page_owner: copy last_migrate_reason in
copy_page_owner()
On 05/26/2016 04:37 AM, js1304@...il.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@....com>
>
> Currently, copy_page_owner() doesn't copy all the owner information.
> It skips last_migrate_reason because copy_page_owner() is used for
> migration and it will be properly set soon. But, following patch
> will use copy_page_owner() and this skip will cause the problem that
> allocated page has uninitialied last_migrate_reason. To prevent it,
> this patch also copy last_migrate_reason in copy_page_owner().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com>
Acked-by: Vlastimil Babka <vbabka@...e.cz>
> ---
> mm/page_owner.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index c6cda3e..73e202f 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -118,6 +118,7 @@ void __copy_page_owner(struct page *oldpage, struct page *newpage)
>
> new_ext->order = old_ext->order;
> new_ext->gfp_mask = old_ext->gfp_mask;
> + new_ext->last_migrate_reason = old_ext->last_migrate_reason;
> new_ext->nr_entries = old_ext->nr_entries;
>
> for (i = 0; i < ARRAY_SIZE(new_ext->trace_entries); i++)
>
Powered by blists - more mailing lists