linux-kernel - Re: [PATCH] perf test: Ignore .scale and other special files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 12:09:45 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	jolsa@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf test: Ignore .scale and other special files

Em Mon, Jun 06, 2016 at 11:54:58AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jun 06, 2016 at 11:51:48AM -0300, Arnaldo Carvalho de Melo escreveu:
> > But this gets us to the following error:
> > 
> > [root@...et ~]# perf test -v 5 2>&1 | tail
> > running test 49 'r1234/name=rawpmu/'
> > running test 50 '4:0x6530160/name=numpmu/'
> > running test 51 'L1-dcache-misses/name=cachepmu/'
> > running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
> > running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
> > running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
> > failed to parse event 'topdown-total-slots:u,cpu/event=topdown-total-slots/u', err 1
> > test child finished with 1
> > ---- end ----
> > parse events tests: FAILED!
> > [root@...et ~]# cat /sys/devices/cpu/events/topdown-total-slots
> > event=0x3c,umask=0x0,any=1[root@...et ~]# 
> > [root@...et ~]# 
> > [root@...et ~]# cat /sys/devices/cpu/events/bus-cycles 
> > event=0x3c,umask=0x01
> > [root@...et ~]# 
> > 
> > I.e seems to be bickering about a missing newline in the sysfs entry, will check the parser...
> 
> Maybe something else, as there are other files there without the newline
> and the code introducing the topdown events doesn't look to be
> problematic in this regard...

[root@...et ~]# perf stat -e cpu/topdown-total-slots/ usleep 1

 Performance counter stats for 'usleep 1':

         1,756,310      cpu/topdown-total-slots/                                    

       0.000797426 seconds time elapsed

[root@...et ~]# perf stat -e cpu/topdown-total-slots/u usleep 1

 Performance counter stats for 'usleep 1':

           606,770      cpu/topdown-total-slots/u                                   

       0.000728467 seconds time elapsed

[root@...et ~]# perf stat -e cpu/event=topdown-total-slots/u usleep 1

 Performance counter stats for 'usleep 1':

           639,170      cpu/event=topdown-total-slots/u                                   

       0.000797547 seconds time elapsed

[root@...et ~]#

Both work, i.e. unrestricted wrt kernel/user, user only (/u suffix),
like in the test, it is just when we try:

[root@...et ~]# perf stat -e topdown-total-slots:u,cpu/event=topdown-total-slots/u usleep 1
event syntax error: 'topdown-total-slots:u,cpu/event=topdown-total-slots/u'
                            \___ parser error
Run 'perf list' for a list of valid events

 Usage: perf stat [<options>] [<command>]

    -e, --event <event>   event selector. use 'perf list' to list available events
[root@...et ~]#

that it fails, Jiri, probably something obvious to you? :-)

- Arnaldo