linux-kernel - [PATCH] of: fix autoloading due to broken modalias with no 'compatible'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1465231718-2577-1-git-send-email-wsa@the-dreams.de>
Date:	Mon,  6 Jun 2016 18:48:38 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	linuxppc-dev@...ts.ozlabs.org
Cc:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Wolfram Sang <wsa@...-dreams.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Andreas Schwab <schwab@...ux-m68k.org>,
	Mathieu Malaterre <malat@...ian.org>
Subject: [PATCH] of: fix autoloading due to broken modalias with no 'compatible'

Because of an improper dereference, a stray 'C' character was output to
the modalias when no 'compatible' was specified. This is the case for
some old PowerMac drivers which only set the 'name' property. Fix it to
let them match again.

Reported-by: Mathieu Malaterre <malat@...ian.org>
Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
Tested-by: Mathieu Malaterre <malat@...ian.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Andreas Schwab <schwab@...ux-m68k.org>
Fixes: 6543becf26fff6 ("mod/file2alias: make modalias generation safe for cross compiling")
---

I think it makes sense if this goes in via ppc (with stable tag added).
D'accord?

 scripts/mod/file2alias.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index a9155077feefb9..fec75786f75bbb 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -384,7 +384,7 @@ static void do_of_entry_multi(void *symval, struct module *mod)
 	len = sprintf(alias, "of:N%sT%s", (*name)[0] ? *name : "*",
 		      (*type)[0] ? *type : "*");
 
-	if (compatible[0])
+	if ((*compatible)[0])
 		sprintf(&alias[len], "%sC%s", (*type)[0] ? "*" : "",
 			*compatible);
 
-- 
2.8.1