[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 18:02:42 +0100
From: Al Viro <viro@...IV.linux.org.uk>
To: Zhao Lei <zhaolei@...fujitsu.com>
Cc: linux-kernel@...r.kernel.org,
containers@...ts.linux-foundation.org,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Mateusz Guzik <mguzik@...hat.com>,
Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH 1/3] Save dump_root into pid_namespace
On Mon, Jun 06, 2016 at 08:02:08PM +0800, Zhao Lei wrote:
> + spin_lock(&pid_ns->root_for_dump_lock);
> +
> + if (pid_ns->root_for_dump.mnt)
> + path_put(&pid_ns->root_for_dump);
NAK, for obvious reasons - don't do blocking operations under spinlocks,
for starters.
Powered by blists - more mailing lists