linux-kernel - Re: [PATCH v4 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 10:06:19 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Peter Griffin <peter.griffin@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	srinivas.kandagatla@...il.com, maxime.coquelin@...com,
	patrice.chotard@...com, ohad@...ery.com,
	bjorn.andersson@...aro.org, arnd@...db.de, lee.jones@...aro.org,
	devicetree@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-remoteproc@...r.kernel.org,
	Ludovic Barre <ludovic.barre@...com>
Subject: Re: [PATCH v4 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA
 driver header file

On Wed, May 25, 2016 at 05:06:39PM +0100, Peter Griffin wrote:

> +/*
> + * request control bits
> + */
> +#define REQ_CTRL_NUM_OPS_MASK		GENMASK(31, 24)
> +#define REQ_CTRL_NUM_OPS(n)		(REQ_CTRL_NUM_OPS_MASK & ((n) << 24))
> +#define REQ_CTRL_INITIATOR_MASK		BIT(22)
> +#define	REQ_CTRL_INIT0			(0x0 << 22)
> +#define	REQ_CTRL_INIT1			(0x1 << 22)

pls keep spaces or tabs, not both :(

> +#define REQ_CTRL_INC_ADDR_ON		BIT(21)
> +#define REQ_CTRL_DATA_SWAP_ON		BIT(17)
> +#define REQ_CTRL_WNR			BIT(14)
> +#define REQ_CTRL_OPCODE_MASK		GENMASK(7, 4)
> +#define REQ_CTRL_OPCODE_LD_ST1		(0x0 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST2		(0x1 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST4		(0x2 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST8		(0x3 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST16		(0x4 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST32		(0x5 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST64		(0x6 << 4)
> +#define REQ_CTRL_HOLDOFF_MASK		GENMASK(2, 0)
> +#define REQ_CTRL_HOLDOFF(n)		((n) & REQ_CTRL_HOLDOFF_MASK)

Everything here is FDMA_ so why not these as well

-- 
~Vinod