linux-kernel - Re: kmemleak report after 9082e87bfbf8 ("block: remove struct bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 12:15:18 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@....de>,
	Shaun Tancheff <shaun.tancheff@...gate.com>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	linux-block@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...com>, Larry.Finger@...inger.net,
	bart.vanassche@...disk.com, drysdale@...gle.com
Subject: Re: kmemleak report after 9082e87bfbf8 ("block: remove struct
 bio_batch")

On 06/06/2016 11:27 AM, Christoph Hellwig wrote:
> On Mon, Jun 06, 2016 at 12:09:49PM -0500, Shaun Tancheff wrote:
>> I'm pretty sure it is missing a bio_put() after submit_bio_wait().
>>
>> Please excuse the hack-y patch but I think you need to do something
>> like this ...
>> (Note tabs eaten by gmail).
>
> Yeah, that makes sense - oddly enough submit_bio_wait doesn't do a
> bio_put. Still not sure why I don't see the leaks after repeated
> mkfs.xfs runs, though.

Because some of the users (blkdev_issue_flush()) need to inspect the bio 
after completion.

-- 
Jens Axboe