lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jun 2016 12:51:43 +0800 From: Frank Wang <frank.wang@...k-chips.com> To: Heiko Stübner <heiko@...ech.de>, Guenter Roeck <linux@...ck-us.net> Cc: dianders@...omium.org, kishon@...com, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-usb@...r.kernel.org, linux-rockchip@...ts.infradead.org, jwerner@...omium.org, xzy.xu@...k-chips.com, huangtao@...k-chips.com, kever.yang@...k-chips.com, william.wu@...k-chips.com, frank.wang@...k-chips.com Subject: Re: [v2, 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy Hi Heiko & Guenter, On 2016/6/4 5:24, Heiko Stübner wrote: > Am Freitag, 3. Juni 2016, 12:59:22 schrieb Guenter Roeck: >> On Thu, Jun 02, 2016 at 02:48:10PM +0800, Frank Wang wrote: >>> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block >>> than rk3288 and before, and most of phy-related registers are also >>> different from the past, so a new phy driver is required necessarily. >>> >>> Signed-off-by: Frank Wang <frank.wang@...k-chips.com> >>> --- >>> >>> Changes in v2: >>> - Changed vbus_host operation from gpio to regulator in *_probe. >>> - Improved the fault treatment relate to 480m clock register. >>> - Cleaned up some meaningless codes in *_clk480m_disable. >>> - made more clear the comment of *_sm_work. >>> >>> [...] >>> >>> +static struct clk * >>> +rockchip_usb2phy_clk480m_register(struct rockchip_usb2phy *rphy) >>> +{ >>> + struct device_node *node = rphy->dev->of_node; >>> + struct clk *clk; >>> + struct clk_init_data init; >>> + int ret; >>> + >>> + init.name = "clk_usbphy_480m"; >>> + init.ops = &rockchip_usb2phy_clkout_ops; >>> + init.flags = CLK_IS_ROOT; >> One more comment: >> >> include/linux/clk-provider.h:#define CLK_IS_ROOT BIT(4) /* >> Deprecated: Don't use */ >> >> ... and the definition has been removed in linux-next. > also, the created clock should be a child of the phy-supply clock. Please take > a look at the picophy-variant (phy-rockchip-usb) that already handles that > parent assignment. > Okay, I will refer and correct them in the next patch (patch v3) . BR. Frank
Powered by blists - more mailing lists