linux-kernel - Re: [PATCH 2/2] sched/debug: fix deadlock when enabling sched events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 16:06:55 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Mel Gorman <mgorman@...hsingularity.net>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] sched/debug: fix deadlock when enabling sched events

On Tue, Jun 07, 2016 at 02:43:17PM -0500, Josh Poimboeuf wrote:
> @@ -403,9 +402,10 @@ DECLARE_EVENT_CLASS(sched_stat_runtime,
>  			(unsigned long long)__entry->vruntime)
>  );
>  
> -DEFINE_EVENT(sched_stat_runtime, sched_stat_runtime,
> -	     TP_PROTO(struct task_struct *tsk, u64 runtime, u64 vruntime),
> -	     TP_ARGS(tsk, runtime, vruntime));
> +DEFINE_EVENT_FN(sched_stat_runtime, sched_stat_runtime,
> +		TP_PROTO(struct task_struct *tsk, u64 runtime, u64 vruntime),
> +		TP_ARGS(tsk, runtime, vruntime),
> +		trace_sched_stat_register, NULL);
>  
>  /*
>   * Tracepoint for showing priority inheritance modifying a tasks

Looking closer at the tracepoints, this one doesn't actually seem to
have a dependency on schedstats as far as I can tell.  So this hunk can
probably be removed.

-- 
Josh