linux-kernel - Re: linux-next: build warning after merge of the mmc-uh tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrfv-35p_7S4XvsmN2NNcw=GfHZCE9ojtXEfijy1eSi5A@mail.gmail.com>
Date:	Tue, 7 Jun 2016 23:42:09 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the mmc-uh tree

On 6 June 2016 at 03:51, Shawn Lin <shawn.lin@...k-chips.com> wrote:
> Hi Stephen,
>
> On 2016/6/6 9:38, Stephen Rothwell wrote:
>>
>> Hi Ulf,
>>
>> After merging the mmc-uh tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/err.h:4:0,
>>                  from drivers/mmc/core/mmc.c:13:
>> drivers/mmc/core/mmc.c: In function 'mmc_select_hs400es':
>> include/linux/err.h:21:49: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
>>  #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned
>> long)-MAX_ERRNO)
>>                                                  ^
>> include/linux/compiler.h:170:42: note: in definition of macro 'unlikely'
>>  # define unlikely(x) __builtin_expect(!!(x), 0)
>>                                           ^
>> drivers/mmc/core/mmc.c:1244:6: note: in expansion of macro 'IS_ERR_VALUE'
>>   if (IS_ERR_VALUE(err))
>>       ^
>
>
> Yup, sorry for this noise. Arnd had removed a lot of IS_ERR_VALUE
> abuses, but I forgot to amend this one.
>
>
> Hi Ulf,
>
> Should I come up with a new fix or you could manually amend it from
> "IS_ERR_VALUE(err)" to "err < 0"? :)
>
>>
>> Introduced by commit
>>
>>   8141f0ace818 ("mmc: core: implement enhanced strobe support")
>>
>> I think error values now must be "long".
>>


Thanks for reporting and fixing!

I have amended the commit above and published the change on my next branch.

Kind regards
Uffe