linux-kernel - Re: [PATCH] scsi: ufs: fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <770e1f6d.59f.1552d0ebd55.Coremail.kernelpatch@126.com>
Date:	Wed, 8 Jun 2016 06:49:48 +0800 (CST)
From:	"Tiezhu Yang" <kernelpatch@....com>
To:	"James Bottomley" <James.Bottomley@...senPartnership.com>
Cc:	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: fix potential memory leak

At 2016-06-08 03:12:08, "James Bottomley" <James.Bottomley@...senPartnership.com> wrote:
>On Wed, 2016-06-08 at 02:00 +0800, Tiezhu Yang wrote:
>> There exists potential memory leak in ufshcd_parse_clock_info(),
>> this patch fixes it.
>
>What makes you think there's a leak here?  These are all devm_
>allocations, so they're all freed when the device is.  If an error is
>returned, the device is released and the memory freed.
>
>You can argue that on successful initialization, there's no need to
>keep the clkfreq array but this patch isn't the way you'd change that.
>
>James
>
OK, thanks. I will send a v2 patch.