linux-kernel - Re: [PATCH 2/2] drm/rockchip: vop: correct the source size of uv scale factor setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 08:57:48 +0800
From:	Mark yao <mark.yao@...k-chips.com>
To:	Yakir Yang <ykk@...k-chips.com>, Mark Yao <yzq@...k-chips.com>,
	Heiko Stuebner <heiko@...ech.de>,
	David Airlie <airlied@...ux.ie>
Cc:	tfiga@...omium.org, dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/rockchip: vop: correct the source size of uv
 scale factor setting

On 2016年06月06日 15:58, Yakir Yang wrote:
> From: Mark Yao <mark.yao@...k-chips.com>
>
> When the input color format is YUV, we need to do some external scale
> for CBCR. Like,
>   * In YUV420 data format:
>       cbcr_xscale = dst_w / src_w * 2;
>       cbcr_yscale = dst_h / src_h * 2;
>   * In YUV422 data format:
>       cbcr_xscale = dst_w / src_w * 2;
>       cbcr_yscale = dst_h / src_h;
>   * In YUV444 data format
>       cbcr_xscale = dst_w / src_w;
>       cbcr_yscale = dst_h / src_h;
>
> Signed-off-by: Yakir Yang <ykk@...k-chips.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 1c4d5b5..b28cda7 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -324,9 +324,9 @@ static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win,
>   			    scl_cal_scale2(src_h, dst_h));
>   		if (is_yuv) {
>   			VOP_SCL_SET(vop, win, scale_cbcr_x,
> -				    scl_cal_scale2(src_w, dst_w));
> +				    scl_cal_scale2(cbcr_src_w, dst_w));
>   			VOP_SCL_SET(vop, win, scale_cbcr_y,
> -				    scl_cal_scale2(src_h, dst_h));
> +				    scl_cal_scale2(cbcr_src_h, dst_h));
>   		}
>   		return;
>   	}
Thanks for this fix, Applied to my drm-fixes.

-- 
Ｍark Yao