linux-kernel - Re: [PATCH] fsnotify: do not initialise statics to false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 09:47:33 +0300
From:	Nikolay Borisov <kernel@...p.com>
To:	Wei Tang <tangwei@...s.chinamobile.com>, john@...nmccutchan.com,
	rlove@...ve.org, eparis@...isplace.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsnotify: do not initialise statics to false



On 06/07/2016 05:17 AM, Wei Tang wrote:
> This patch fixes the checkpatch.pl error to inotify_fsnotify.c:
> 
> ERROR: do not initialise statics to false

So if a variable is declared as static this means it's going to live in
the BSS which is zeroed out on load. So implicitly it is going to be 0,
however I think this is a subtle detail. I personally rather have the
false there and live with the warning. Not everything that checkpatch
reports must be fixed.


> 
> Signed-off-by: Wei Tang <tangwei@...s.chinamobile.com>
> ---
>  fs/notify/inotify/inotify_fsnotify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c
> index 2cd900c..09c5393 100644
> --- a/fs/notify/inotify/inotify_fsnotify.c
> +++ b/fs/notify/inotify/inotify_fsnotify.c
> @@ -136,7 +136,7 @@ static int idr_callback(int id, void *p, void *data)
>  {
>  	struct fsnotify_mark *fsn_mark;
>  	struct inotify_inode_mark *i_mark;
> -	static bool warned = false;
> +	static bool warned;
>  
>  	if (warned)
>  		return 0;
>