linux-kernel - Re: [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607071144.GK30909@twins.programming.kicks-ass.net>
Date:	Tue, 7 Jun 2016 09:11:45 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	Julien Desfossez <jdesfossez@...icios.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] sched: encapsulate priority changes in a
 sched_set_prio static function

On Mon, Jun 06, 2016 at 09:47:52PM +0000, Mathieu Desnoyers wrote:
> >> +++ b/kernel/sched/core.c
> >> @@ -2230,6 +2230,11 @@ int sysctl_schedstats(struct ctl_table *table, int write,
> >> #endif
> >> #endif
> >> 
> >> +static void sched_set_prio(struct task_struct *p, int prio)
> >> +{
> >> +	p->prio = prio;
> >> +}

Urgh; so there's a bunch of patches to the PI code that I've been
ignoring that'll completely break all this.

Let me dig them up and get this all sorted.

Basically, looking at @prio is broken.