linux-kernel - Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607083820.stlhphzuy27rx5ze@c203.arch.suse.de>
Date:	Tue, 7 Jun 2016 10:38:21 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Christoph Hellwig <hch@....de>
Cc:	axboe@...nel.dk, keith.busch@...el.com,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org
Subject: Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields

On Tue, Jun 07, 2016 at 10:10:09AM +0200, Johannes Thumshirn wrote:
> On Mon, Jun 06, 2016 at 11:20:43PM +0200, Christoph Hellwig wrote:
> > These have been added in NVMe 1.2 and we'll need at least oaes for the
> > NVMe target driver.
> > 
> > Reviewed-by: Sagi Grimberg <sagi@...mberg.me>
> > Reviewed-by: Jay Freyensee <james.p.freyensee@...el.com>
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > ---
> >  include/linux/nvme.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> > index 7d51b29..ff5ebc3 100644
> > --- a/include/linux/nvme.h
> > +++ b/include/linux/nvme.h
> > @@ -107,7 +107,10 @@ struct nvme_id_ctrl {
> >  	__u8			mdts;
> >  	__le16			cntlid;
> >  	__le32			ver;
> > -	__u8			rsvd84[172];
> > +	__le32			rtd3r;
> > +	__le32			rtd3e;
> > +	__le32			oaes;
> 
> Just out of curiosity, why not CTRATT as well?

OK found the patch adding it myself.

Sorry,
	Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850