linux-kernel - Re: [PATCH] perf/core: make account/unaccount_sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607091546.GB1170@pd.tnic>
Date:	Tue, 7 Jun 2016 11:15:46 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	David Carrillo-Cisneros <davidcc@...gle.com>
Cc:	linux-kernel@...r.kernel.org, "x86@...nel.org" <x86@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Kan Liang <kan.liang@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf/core: make account/unaccount_sb_event consistent

On Wed, Jun 01, 2016 at 12:33:05PM -0700, David Carrillo-Cisneros wrote:
> unaccount_pmu_sb_event did not check for attributes in event->attr
> before calling detach_sb_event, while account_pmu_event did.
> 
> This caused NULL pointer reference in cgroup events that did not
> have any of the attributes checked by account_pmu_event.
> 
> To trigger the bug just wait for a cgroup event to terminate, e.g.:
> 
> $ mkdir /dev/cgroup/devices/test
> $ perf stat -e cycles -a -G test sleep 0
> 
> ... see crash ...
> 
> Patch rebased on peterz/queue/perf/core .
> 
> Reviewed-by: Stephane Eranian <eranian@...gle.com>
> Signed-off-by: David Carrillo-Cisneros <davidcc@...gle.com>
> ---
>  kernel/events/core.c | 34 ++++++++++++++++++----------------
>  1 file changed, 18 insertions(+), 16 deletions(-)

Tested-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.