linux-kernel - Re: [PATCH] pinctrl: tegra: Fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575691EE.8020409@nvidia.com>
Date:	Tue, 7 Jun 2016 10:20:46 +0100
From:	Jon Hunter <jonathanh@...dia.com>
To:	Axel Lin <axel.lin@...ics.com>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: tegra: Fix build dependency


On 07/06/16 10:17, Jon Hunter wrote:
> 
> On 04/06/16 07:35, Axel Lin wrote:
>> I got below build error:
>> ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] undefined!
>> with below build configuration:
>> CONFIG_ARCH_TEGRA=y
>> CONFIG_PINCTRL_TEGRA_XUSB=y
>> CONFIG_PHY_TEGRA_XUSB=y
> 
> The above does not make sense because the error is from building a
> module but you say you have CONFIG_PINCTRL_TEGRA_XUSB=y. Shouldn't this
> be CONFIG_PINCTRL_TEGRA_XUSB=m? However, the error will occur either if
> you compile as a module or not, but the changelog should be accurate
> nonetheless.

Sorry I meant CONFIG_PHY_TEGRA_XUSB=m and NOT
CONFIG_PINCTRL_TEGRA_XUSB=m as you are building the phy-tegra-xusb as a
module.

Jon

--
nvpublic