linux-kernel - linux-4.7-rc2/drivers/net/fjes/fjes_main.c:1346]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 10:46:41 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	dcb314@...mail.com
Subject: linux-4.7-rc2/drivers/net/fjes/fjes_main.c:1346]: (style) Redundant condition

Hello there,

linux-4.7-rc2/drivers/net/fjes/fjes_main.c:1346]: (style) Redundant
condition: !is_shared. 'is_shared && (!is_shared || !stop_req_done)'
is equivalent to 'is_shared && !stop_req_done'

Source code is

            if ((!stop_req ||
                 (is_shared && (!is_shared || !stop_req_done))) &&
                (is_shared || !unshare_watch || !unshare_reserve))

          if ((!stop_req ||
                 (is_shared && !stop_req_done)) &&
                (is_shared || !unshare_watch || !unshare_reserve))

Also in the same file:

[drivers/net/fjes/fjes_main.c:1321]: (style) Variable 'max_epid' is
assigned a value that is never used.
[drivers/net/fjes/fjes_main.c:1320]: (style) Variable 'my_epid' is
assigned a value that is never used.

These two might be candidates for deletion.

Regards

David Binderman