linux-kernel - Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607104711.GR7510@sirena.org.uk>
Date:	Tue, 7 Jun 2016 11:47:11 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Xing Zheng <zhengxing@...k-chips.com>
Cc:	Rob Herring <robh@...nel.org>, linux-rockchip@...ts.infradead.org,
	dianders@...omium.org, heiko@...ech.de,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for
 MAX98357A/RT5514/DA7219

On Tue, Jun 07, 2016 at 10:49:35AM +0800, Xing Zheng wrote:
> On 2016年06月07日 07:50, Mark Brown wrote:

> > It should probably be three compatibles, one per CODEC, if the driver
> > needs to handle each separately.

> Do you mean like this:
> --------
> sound {
> compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
> 
> dailink-0 {
> compatible = "rockchip,rk3399-max98357a";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&max98357a>;
> };
> 
> dailink-1 {
> compatible = "rockchip,rk3399-rt5514";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&headsetcodec>;
> };
> 
> dailink-2 {
> compatible = "rockchip,rk3399-da7219";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&codec>;
> };
> };
> --------
> Above, the machine drvier will handle them. Please correct me if I
> misunderstand.

No, that'd be one card with all three CODECs on the same board which I'm
guessing isn't the intention?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)