[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160607025459.GV3766@xsjsorenbubuntu>
Date: Mon, 6 Jun 2016 19:54:59 -0700
From: Sören Brinkmann <soren.brinkmann@...inx.com>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
CC: <linux-kernel@...r.kernel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Michal Simek <michal.simek@...inx.com>,
<linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular
On Mon, 2016-06-06 at 22:43:06 -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_ZYNQ
> bool "Pinctrl driver for Xilinx Zynq"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Acked-by: "Sören Brinkmann" <soren.brinkmann@...inx.com>
Sören
Powered by blists - more mailing lists