linux-kernel - Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5756C245.7010001@rock-chips.com>
Date:	Tue, 07 Jun 2016 20:47:01 +0800
From:	Xing Zheng <zhengxing@...k-chips.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Rob Herring <robh@...nel.org>, linux-rockchip@...ts.infradead.org,
	dianders@...omium.org, heiko@...ech.de,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219

Hi Mark,

On 2016年06月07日 20:06, Mark Brown wrote:
> OK, then the original name probably makes some sense though really
> that's such an unusual design that just naming it after the specific
> board might be better, it's not likely to see any reuse I'd guess.
There are not only one type of board with this audio connection, so I 
think we don't need to add specific board name.

Therefore, I intend to recover original name 
(rk3399_max98357a_rt5514_da7219.c), and description like this:
sound {
     compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
     rockchip,cpu = <&i2s0 &i2s0 &i2s0>;               // note (will not 
be sent to upstream): In future, we may use the i2s1 or i2s2...
     rockchip,codec = <&max98357a &headsetcodec &codec>;
};

Could you please agree to do this?

Thanks.

-- 
- Xing Zheng