linux-kernel - Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607132259.GA13083@neilslaptop.think-freely.org>
Date:	Tue, 7 Jun 2016 09:22:59 -0400
From:	Neil Horman <nhorman@...hat.com>
To:	David Kershner <david.kershner@...sys.com>
Cc:	corbet@....net, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, gregkh@...uxfoundation.org,
	erik.arfvidson@...sys.com, timothy.sell@...sys.com,
	hofrat@...dl.org, dzickus@...hat.com, jes.sorensen@...hat.com,
	alexander.curtin@...sys.com, janani.rvchndrn@...il.com,
	sudipm.mukherjee@...il.com, prarit@...hat.com,
	david.binder@...sys.com, dan.j.williams@...el.com,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, sparmaintainer@...sys.com
Subject: Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module
 parameters

On Sat, Jun 04, 2016 at 01:27:04PM -0400, David Kershner wrote:
> From: David Binder <david.binder@...sys.com>
> 
> Removes unused module parameters from visorbus_main.c, in response to
> findings by SonarQube.
> 
> Signed-off-by: David Binder <david.binder@...sys.com>
> Signed-off-by: David Kershner <david.kershner@...sys.com>
> Reviewed-by: Tim Sell <Timothy.Sell@...sys.com>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 2ed9628..71bff07 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -27,10 +27,9 @@
>  #define MYDRVNAME "visorbus"
>  
>  /* module parameters */
> -static int visorbus_debug;
>  static int visorbus_forcematch;
>  static int visorbus_forcenomatch;
> -static int visorbus_debugref;
> +
>  #define SERIALLOOPBACKCHANADDR (100 * 1024 * 1024)
>  
>  /* Display string that is guaranteed to be no longer the 99 characters*/
> @@ -1332,9 +1331,6 @@ visorbus_exit(void)
>  	remove_bus_type();
>  }
>  
> -module_param_named(debug, visorbus_debug, int, S_IRUGO);
> -MODULE_PARM_DESC(visorbus_debug, "1 to debug");
> -
>  module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
>  MODULE_PARM_DESC(visorbus_forcematch,
>  		 "1 to force a successful dev <--> drv match");
> @@ -1342,6 +1338,3 @@ MODULE_PARM_DESC(visorbus_forcematch,
>  module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
>  MODULE_PARM_DESC(visorbus_forcenomatch,
>  		 "1 to force an UNsuccessful dev <--> drv match");
> -
> -module_param_named(debugref, visorbus_debugref, int, S_IRUGO);
> -MODULE_PARM_DESC(visorbus_debugref, "1 to debug reference counting");

visorbus_forcematch and visorbus_forcenomatch appear to be referenced in
visorbus_match (at least in the HEAD of linus' tree).  If you're going to remove
the module parameters, why not also remove those references and the
force[no]match variables themselves?

Neil