linux-kernel - RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2FF1F92@RTITMBSV03.realtek.com.tw>
Date:	Tue, 7 Jun 2016 13:59:11 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Mario Limonciello <mario_limonciello@...l.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	Linux USB <linux-usb@...r.kernel.org>,
	"pali.rohar@...il.com" <pali.rohar@...il.com>,
	"anthony.wong@...onical.com" <anthony.wong@...onical.com>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: RE: [PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

Mario Limonciello [mailto:mario_limonciello@...l.com]
[...]
> +		ret = hex2bin(buf, obj->string.pointer + 9, 6);
> +		if (ret < 0 || !is_valid_ether_addr(buf)) {
> +			netif_warn(tp, probe, tp->netdev, "Invalid MAC\n");
> +			goto amacout;
> +		}

If hex2bin() is success, the ret would be 0.
And you would return 0 when !is_valid_ether_addr(buf) occurs.
I don't think it is what you wants.

Best Regards,
Hayes