linux-kernel - Re: [RFC v4 2/4] crypto: Introduce CRYPTO_ALG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 22:16:13 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	axboe@...nel.dk, agk@...hat.com, snitzer@...hat.com,
	dm-devel@...hat.com, davem@...emloft.net, ebiggers3@...il.com,
	js1304@...il.com, tadeusz.struk@...el.com, smueller@...onox.de,
	standby24x7@...il.com, shli@...nel.org, dan.j.williams@...el.com,
	martin.petersen@...cle.com, sagig@...lanox.com,
	kent.overstreet@...il.com, keith.busch@...el.com, tj@...nel.org,
	ming.lei@...onical.com, broonie@...nel.org, arnd@...db.de,
	linux-crypto@...r.kernel.org, linux-block@...r.kernel.org,
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC v4 2/4] crypto: Introduce CRYPTO_ALG_BULK flag

On Tue, Jun 07, 2016 at 08:17:05PM +0800, Baolin Wang wrote:
> Now some cipher hardware engines prefer to handle bulk block rather than one
> sector (512 bytes) created by dm-crypt, cause these cipher engines can handle
> the intermediate values (IV) by themselves in one bulk block. This means we
> can increase the size of the request by merging request rather than always 512
> bytes and thus increase the hardware engine processing speed.
> 
> So introduce 'CRYPTO_ALG_BULK' flag to indicate this cipher can support bulk
> mode.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>

Nack.  As I said before, please do it using explicit IV generators
like we do for IPsec.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt