linux-kernel - Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 09:17:09 -0500
From:	atull <atull@...nsource.altera.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Moritz Fischer <moritz.fischer@...us.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:

> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Moritz Fischer <moritz.fischer@...us.com>

Acked-by: Alan Tull <atull@...nsource.altera.com>

Thanks!
Alan

> ---
> v2:
>   - Add Reviewed-by,
>   - Updated error message for recent kernels,
>   - Submit to Greg, as requested by Alan.
> ---
>  drivers/fpga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>  
>  config FPGA_MGR_ZYNQ_FPGA
>  	tristate "Xilinx Zynq FPGA"
> +	depends on HAS_DMA
>  	help
>  	  FPGA manager driver support for Xilinx Zynq FPGAs.
>  
> -- 
> 1.9.1
> 
>