linux-kernel - linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 16:27:55 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	mbroemme@...sserver.de, plagnioj@...osoft.com,
	tomi.valkeinen@...com, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, dcb314@...mail.com
Subject: linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style)
 Redundant condition

Hello there,

linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style)
Redundant condition: If 'msrc > 1', the comparison 'msrc' is always
true.

Source code is

            if (msrc && msrc > 1) {

Maybe better code

            if (msrc > 1) {


Regards

David Binderman