linux-kernel - Re: [PATCH] cgroup: disable irqs while holding css_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160607161134.GU9340@e106622-lin>
Date:	Tue, 7 Jun 2016 17:11:34 +0100
From:	Juri Lelli <juri.lelli@....com>
To:	Daniel Bristot de Oliveira <daolivei@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Rik van Riel <riel@...hat.com>,
	"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
	Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>,
	Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org
Subject: Re: [PATCH] cgroup: disable irqs while holding css_set_lock

On 07/06/16 12:26, Daniel Bristot de Oliveira wrote:
> Ciao Juri,
> 
> On 06/07/2016 10:30 AM, Juri Lelli wrote:
> > So, this and the partitioned one could actually overlap, since we don't
> > set cpu_exclusive. Is that right?
> > 
> > I guess affinity mask of both m processes gets set correclty, but I'm
> > not sure if we are missing one check in the admission control. Can you
> > actually create two overlapping sets and get DEADLINE tasks running in
> > them? For example, what happens if partitioned is [4] and clustered is
> > [4-7]? Does setattr() fail?
> 
> That is what I was trying to understand/break. Fortunately, I still
> can't break it! bravo! :-)
> 
> In the test you mentioned the task in the "clustered" fails to
> sched_setattr().
> 
> Test output example:
> + '[' '!' -d partitioned ']'
> + mkdir partitioned
> + echo 4
> + echo 0
> + echo 0
> + echo 1155
> + cat /proc/self/cpuset
> /partitioned
> + /root/m
> main thread [1162]
> deadline thread started [1164]

Mmm. The other one is good, but this one looks still suspect to me. We
shouldn't have created a new root domain at this point (since
cpu_exclusive is not set), so we shouldn't be able to admit DEADLINE
tasks with a smaller affinity mask than the full root domain mask (which
should still be 0-7 at this point), if I'm interpreting your script correctly
and I'm not wrong about root domains stuff.

Unfortunately I'm not able to test this myself right now. Hopefully next
week.

Thanks a lot for testing, though!

Best,

- Juri

> + '[' '!' -d clustered ']'
> + mkdir clustered
> + echo 4-7
> + echo 0
> + echo 0
> + echo 1
> + echo 1155
> + cat /proc/self/cpuset
> + /root/m
> /clustered
> + /root/m
> main thread [1166]
> sched_setattr: Operation not permitted
> 
> I will let you know if I find something odd.
> 
> -- Daniel
>