linux-kernel - Re: [PATCH V3 1/2] thermal: max77620: Add DT binding doc for thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575645B8.5090709@ti.com>
Date:	Tue, 7 Jun 2016 09:25:36 +0530
From:	Keerthy <a0393675@...com>
To:	Laxman Dewangan <ldewangan@...dia.com>, <edubezval@...il.com>,
	<rui.zhang@...el.com>, <robh+dt@...nel.org>
CC:	<linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] thermal: max77620: Add DT binding doc for thermal
 driver



On Monday 06 June 2016 05:14 PM, Laxman Dewangan wrote:
> Maxim Semiconductor MAX77620 supports alarm interrupts when
> its die temperature crosses 120C and 140C. These threshold
> temperatures are not configurable.
>
> Add DT binding document to details out the DT property related
> to MAX77620 thermal functionality.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>   .../bindings/thermal/thermal-max77620.txt          | 64 ++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/thermal/thermal-max77620.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-max77620.txt b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
> new file mode 100644
> index 0000000..5a500d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/thermal-max77620.txt
> @@ -0,0 +1,64 @@
> +Thermal driver for MAX77620 Power management IC from Maxim Semiconductor.
> +
> +Maxim Semiconductor MAX77620 supports alarm interrupts when its
> +die temperature crosses 120C and 140C. These threshold temperatures
> +are not configurable. Device does not provide the real temperature
> +of die other than just indicating whether temperature is above or
> +below threshold level.
> +
> +Required properties:
> +-------------------
> +#thermal-sensor-cells:	Please refer <devicetree/bindings/thermal/thermal.txt>
> +			for more details.
> +			The value must be 0.
> +
> +For more details, please refer generic thermal DT binding document
> +<devicetree/bindings/thermal/thermal.txt>.
> +
> +Please refer <devicetree/bindings/mfd/max77620.txt> for mfd DT binding
> +document for the MAX77620.
> +
> +Example:
> +--------
> +#include <dt-bindings/mfd/max77620.h>
> +#include <dt-bindings/thermal/thermal.h>
> +...
> +
> +i2c@...0d000 {
> +	spmic: max77620@3c {
> +		compatible = "maxim,max77620";
> +		:::::
> +		#thermal-sensor-cells = <0>;
> +		:::
> +	};
> +};
> +
> +cool_dev: cool-dev {
> +	compatible = "cooling-dev";
> +	#cooling-cells = <2>;
> +};
> +
> +thermal-zones {
> +	PMIC-Die {
> +		polling-delay = <0>;
> +		polling-delay-passive = <0>;
> +		thermal-sensors = <&spmic>;
> +
> +		trips {
> +			die_temp_thresh: hot-die {
> +				temperature = <120000>;
> +				type = "active";
> +				hysteresis = <0>;
> +			};
> +		};

What about 140C? Isn't that a critical trip point?

> +
> +		cooling-maps {
> +			map0 {
> +				trip = <&die_temp_thresh>;
> +				cooling-device = <&cool_dev THERMAL_NO_LIMIT
> +						  THERMAL_NO_LIMIT>;
> +				contribution = <100>;
> +			};
> +		};
> +	};
> +};
>