linux-kernel - RE: [PATCH V2 2/2] crypto : async implementation for sha1-mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C440BA31B54DCD4AAC682D2365C8FEE703C662A9@ORSMSX111.amr.corp.intel.com>
Date:	Tue, 7 Jun 2016 18:10:14 +0000
From:	"Dey, Megha" <megha.dey@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	"Megha Dey" <megha.dey@...ux.intel.com>
Subject: RE: [PATCH V2 2/2] crypto : async implementation for sha1-mb



-----Original Message-----
From: Herbert Xu [mailto:herbert@...dor.apana.org.au] 
Sent: Tuesday, June 7, 2016 3:35 AM
To: Dey, Megha <megha.dey@...el.com>
Cc: tim.c.chen@...ux.intel.com; davem@...emloft.net; linux-crypto@...r.kernel.org; linux-kernel@...r.kernel.org; Yu, Fenghua <fenghua.yu@...el.com>; Megha Dey <megha.dey@...ux.intel.com>
Subject: Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb

On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote:
>
> +	struct ahash_alg *shash = crypto_ahash_alg(tfm);
>  
>  	/* alignment is to be done by multi-buffer crypto algorithm if 
> needed */
>  
> -	return shash->finup(desc, NULL, 0, req->result);
> +	return shash->finup(desc);

You're still poking in the guts of the API.  Now that it's a real ahash you don't need to do that.

Just do crypto_ahash_finup.  That way you don't need to export crypto_ahsh_alg either.

> I have made these changes and re-sent the patch.

Thanks,
--
Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt