linux-kernel - Re: [PATCH 0/2] Proper ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKUSTFOURYaP5J6PangAGFjDv+x17Hr=coJgfCPk8SQsw@mail.gmail.com>
Date:	Tue, 7 Jun 2016 11:11:17 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] Proper ro_after_init implementation on s390

On Tue, Jun 7, 2016 at 11:07 AM, Heiko Carstens
<heiko.carstens@...ibm.com> wrote:
> On Tue, Jun 07, 2016 at 08:49:14AM -0700, Kees Cook wrote:
>> > Heiko Carstens (2):
>> >   vmlinux.lds.h: allow arch specific handling of ro_after_init data section
>> >   s390/mm: add proper __ro_after_init support
>> >
>> >  arch/s390/include/asm/cache.h     |  3 ---
>> >  arch/s390/include/asm/sections.h  |  1 +
>> >  arch/s390/kernel/vmlinux.lds.S    | 12 +++++++++++-
>> >  arch/s390/mm/init.c               |  7 ++++---
>> >  arch/s390/mm/vmem.c               |  7 +++----
>> >  include/asm-generic/vmlinux.lds.h | 10 +++++++++-
>> >  6 files changed, 28 insertions(+), 12 deletions(-)
>>
>> Awesome! This looks great to me! Have you had a chance to look through
>> any of the arch/s390/ __init code for variables that should be marked
>> __ro_after_init?
>
> Not yet, and actually this I'm a bit reluctant to do that, since any wrong
> annotation will lead to kernel crashes sooner or later ;)
> However I'll look into this as well.

Yup, though the good news is it's usually discovered very quickly. :)

>> Reviewed-by: Kees Cook <keescook@...omium.org>
>
> Thanks! I add that to both patches.
>
> (sorry for the broken threading; one of the outgoing mail servers rewrote
> all Message-Id headers)

Cool, no worries. I tried to reply to what looked like the right one. :)

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security