linux-kernel - Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160608174050.GB16615@roeck-us.net>
Date:	Wed, 8 Jun 2016 10:40:50 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Brian Norris <briannorris@...omium.org>
Cc:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	linux-kernel@...r.kernel.org,
	Brian Norris <computersforpeace@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] nvmem: fix nvmem_cell_read() return type for
 !CONFIG_NVMEM

On Wed, Jun 08, 2016 at 09:40:11AM -0700, Brian Norris wrote:
> On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote:
> > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM
> > it returns char *. Let's make that consistent. Also drop the
> > incorrect/inconsistent comment about char * above the nvmem_cell_read()
> > definition.
> > 
> > drivers/thermal/mtk_thermal.c is already working around this by casting
> > to (u32 *).
> > 
> > Signed-off-by: Brian Norris <briannorris@...omium.org>
> 
> Seems Guenter submitted the same thing a week ago, with no response:
> 
> https://patchwork.kernel.org/patch/9148325/
> 
> I'll selfishly suggest that mine is better, since it also corrects the
> comments :)
> 
Perfectly fine with me.

Guenter