[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160608194824.GC28348@f23x64.localdomain>
Date: Wed, 8 Jun 2016 12:48:24 -0700
From: Darren Hart <dvhart@...radead.org>
To: Pali Rohár <pali.rohar@...il.com>
Cc: Michał Kępień <kernel@...pniu.pl>,
Matthew Garrett <mjg59@...f.ucam.org>,
Gabriele Mazzotta <gabriele.mzt@...il.com>,
Mario Limonciello <mario_limonciello@...l.com>,
Andy Lutomirski <luto@...nel.org>,
Alex Hung <alex.hung@...onical.com>,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments
On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Rohár wrote:
> On Thursday 02 June 2016 12:41:42 Michał Kępień wrote:
> > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> >
> > My guess is that Darren won't let you off without at least a short
> > commit message.
>
> I have no idea what else to write. I think that description is enough.
There is always something. For example, why? See Documentation/SubmittingPatches
section "14) The canonical patch format" for an explanation.
"Traceability" of changes is important. If it's worth preparing the patch, it's
worth documenting why.
--
Darren Hart
Intel Open Source Technology Center
Powered by blists - more mailing lists