linux-kernel - [PATCH] staging: comedi: serial2002: bare unsigned and unneeded cast styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1465415971-30203-1-git-send-email-chris.cesare@gmail.com>
Date:	Wed,  8 Jun 2016 15:59:31 -0400
From:	Chris Cesare <chris.cesare@...il.com>
To:	abbotti@....co.uk
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Chris Cesare <chris.cesare@...il.com>
Subject: [PATCH] staging: comedi: serial2002: bare unsigned and unneeded cast styling issues

checkpatch.pl reported two warnings: A bare "unsigned" and an
unnecessary cast. Fixed both.

Signed-off-by: Chris Cesare <chris.cesare@...il.com>
---
 drivers/staging/comedi/drivers/serial2002.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c
index 7a1defc..d3c2743 100644
--- a/drivers/staging/comedi/drivers/serial2002.c
+++ b/drivers/staging/comedi/drivers/serial2002.c
@@ -95,7 +95,7 @@ struct serial_data {
 #define S2002_CFG_SIGN(x)		(((x) >> 13) & 0x1)
 #define S2002_CFG_BASE(x)		(((x) >> 14) & 0xfffff)
 
-static long serial2002_tty_ioctl(struct file *f, unsigned op,
+static long serial2002_tty_ioctl(struct file *f, unsigned int op,
 				 unsigned long param)
 {
 	if (f->f_op->unlocked_ioctl)
@@ -379,7 +379,8 @@ static int serial2002_setup_subdevice(struct comedi_subdevice *s,
 				range_table_list[chan] =
 				    (const struct comedi_lrange *)&range[j];
 			}
-			maxdata_list[chan] = ((long long)1 << cfg[j].bits) - 1;
+			maxdata_list[chan] = (1 << cfg[j].bits) - 1;
+
 			chan++;
 		}
 	}
-- 
2.7.4