linux-kernel - Re: [PATCH] Fix NFS option parsing bit-rot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com>
Date:	Wed, 8 Jun 2016 20:35:21 +0000
From:	Trond Myklebust <trondmy@...marydata.com>
To:	Rob Landley <rob@...dley.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anna Schumaker <anna.schumaker@...app.com>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH] Fix NFS option parsing bit-rot.

On 6/8/16, 15:41, "Rob Landley" <rob@...dley.net> wrote:
>So addr= is at _best_ redundant. You MUST supply host:/ always,
>the current code just wasn't using it.

That’s because you just happen to be supplying an IP address instead of a hostname. The kernel has no DNS resolving functionality. It cannot resolve hostnames into IP addresses without help either by the caller or by means of an upcall. That is why ‘addr=’ has been a mandatory parameter ever since we introduced the text based parser.

Now we could, theoretically, have the client call nfs_dns_resolve_name() on the hostname to resolve it. However that breaks when you have net namespaces and such, since the kernel’s dns_query() call is not container aware.

Trond