linux-kernel - Re: [PATCH] ASoC: cs53l30: Correct clock inversion check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 16:09:38 -0700
From:	Nicolin Chen <nicoleotsuka@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Brian Austin <brian.austin@...rus.com>,
	Paul Handrigan <Paul.Handrigan@...rus.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: cs53l30: Correct clock inversion check

On Wed, Jun 8, 2016 at 4:03 PM, Nicolin Chen <nicoleotsuka@...il.com> wrote:
> SND_SOC_DAIFMT_IB_NF = 0x3 (11b) | SND_SOC_DAIFMT_IB_IF = 0x4 (100b)
> creates a mask 0x7 (111b) which also includes SND_SOC_DAIFMT_IB_NF

Oops, here should be NB_IF for (10b). Will send v2. Please ignore this one.

> = 0x2 (10b).
>
> So this patch uses the traditional way to check the clock inversion.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
>  sound/soc/codecs/cs53l30.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
> index ac90dd7..62daa0c 100644
> --- a/sound/soc/codecs/cs53l30.c
> +++ b/sound/soc/codecs/cs53l30.c
> @@ -598,8 +598,14 @@ static int cs53l30_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
>         }
>
>         /* Check to see if the SCLK is inverted */
> -       if (fmt & (SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_IB_IF))
> +       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> +       case SND_SOC_DAIFMT_IB_NF:
> +       case SND_SOC_DAIFMT_IB_IF:
>                 aspcfg ^= CS53L30_ASP_SCLK_INV;
> +               break;
> +       default:
> +               break;
> +       }
>
>         regmap_update_bits(priv->regmap, CS53L30_ASPCFG_CTL,
>                            CS53L30_ASP_MS | CS53L30_ASP_SCLK_INV, aspcfg);
> --
> 2.1.4
>