linux-kernel - Re: [PATCH] Staging: unisys: visorhba: visorhba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 22:59:58 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Rumesh Hapuarachchi <rehrumesh@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: unisys: visorhba: visorhba_main: fixed a coding
 style issue

On Sat, May 21, 2016 at 12:30:46AM +0530, Rumesh Hapuarachchi wrote:
> fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned'
> 
> Signed-off-by: Rumesh Hapuarahcchi <rehrumesh@...il.com>
> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 6a4570d..3b69b33 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1122,9 +1122,9 @@ static int visorhba_probe(struct visor_device *dev)
>  	if (err < 0)
>  		goto err_scsi_host_put;
>  
> -	scsihost->max_id = (unsigned)max.max_id;
> -	scsihost->max_lun = (unsigned)max.max_lun;
> -	scsihost->cmd_per_lun = (unsigned)max.cmd_per_lun;
> +	scsihost->max_id = (unsigned int)max.max_id;
> +	scsihost->max_lun = (unsigned int)max.max_lun;
> +	scsihost->cmd_per_lun = (unsigned int)max.cmd_per_lun;
>  	scsihost->max_sectors =
>  	    (unsigned short)(max.max_io_size >> 9);
>  	scsihost->sg_tablesize =

Someone else sent this patch for this issue before you did, sorry :(