linux-kernel - Re: [PATCH] gpio: 104-dio-48e: Fix control port offset computation off-by-one error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdawGmR6oLG-Vvs=O=KsLM=8RmSSF7M-xCh-A4vgnk+-pw@mail.gmail.com>
Date:	Wed, 8 Jun 2016 10:08:34 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: 104-dio-48e: Fix control port offset computation
 off-by-one error

On Thu, Jun 2, 2016 at 10:00 PM, William Breathitt Gray
<vilhelm.gray@...il.com> wrote:

> There are only two control ports, each controlling three distinct I/O
> ports. To compute the control port address offset for a respective I/O
> port, the I/O port address offset should be divided by 3; dividing by 2
> may result in not only the wrong address offset but possibly also an
> out-of-bounds array memory access for a non-existent third control port.
>
> Fixes: 1b06d64f7374 ("gpio: Add GPIO support for the ACCES 104-DIO-48E")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>

Patch applied.

Yours,
Linus Walleij