linux-kernel - Re: small patch to avoid warning in gcc 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465346866.25087.45.camel@perches.com>
Date:	Tue, 07 Jun 2016 17:47:46 -0700
From:	Joe Perches <joe@...ches.com>
To:	Reinoud Koornstra <reinoudkoornstra@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: small patch to avoid warning in gcc 6

On Tue, 2016-06-07 at 18:41 -0600, Reinoud Koornstra wrote:
> Hello Everybody,
> 
> A small patch that doesn't really do anything other than getting rid
> of a warning in gcc 6.1.0.
> 
> drivers/gpu/drm/i915/i915_debugfs.c: In function ‘i915_dump_lrc’:
> drivers/gpu/drm/i915/i915_debugfs.c:2060:6: warning: suggest explicit
> braces to avoid ambiguous ‘else’ [-Wparentheses]
>    if (ctx != dev_priv->kernel_context)
>       ^

Likely there should be 2 pairs of braces added:

	list_for_each_entry(ctx, &dev_priv->context_list, link) {
		if (ctx != dev_priv->kernel_context) {
                        for_each_ring(ring, dev_priv, i)
                                i915_dump_lrc_obj(m, ctx, ring);
		}
	}