linux-kernel - Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 09:46:45 +0100
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Baruch Siach <baruch@...s.co.il>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kishon@...com, lee.jones@...aro.org, patches@...aro.org
Subject: Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM
 error message

Hi Baruch,

On Tue, 07 Jun 2016, Baruch Siach wrote:

> Hi Peter,
> 
> On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote:
> > kzalloc will issue its own error message including a dump_stack()
> > so remote the site specific message.
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > ---
> >  drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > index 56631e7..958e9cc 100644
> > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
> >  	int err = 0;
> >  
> >  	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
> > -	if (!phy) {
> > -		dev_err(dev, "%s: failed to allocate phy\n", __func__);
> > +	if (!phy)
> >  		err = -ENOMEM;
> >  		goto out;
> > -	}
> 
> Are you sure? The 'goto' is now unconditional.

Your correct... that is not what I intended to do! Will send a v2.

regards,

Peter.