linux-kernel - Re: [PATCH] gpio: lpc18xx: convert GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbXmX+eqAFnmjZFG3Xv_gbt-8MtJnpvyWQ5RX-tThez_g@mail.gmail.com>
Date:	Wed, 8 Jun 2016 11:04:25 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Joachim Eastwood <manabian@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate

On Sun, Jun 5, 2016 at 8:23 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
>  config GPIO_LPC18XX
>        bool "NXP LPC18XX/43XX GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> When targeting orphaned modular code in non-modular drivers, this
> came up.  Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident.  So here we make it
> tristate instead of removing the modular code that was essentially
> orphaned.
>
> Cc: Joachim Eastwood <manabian@...il.com>
> Acked-by: Joachim Eastwood <manabian@...il.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied.

Yours,
Linus Walleij