linux-kernel - [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465379444-14719-1-git-send-email-honghui.zhang@mediatek.com>
Date:	Wed, 8 Jun 2016 17:50:44 +0800
From:	<honghui.zhang@...iatek.com>
To:	<joro@...tes.org>, <treding@...dia.com>, <mark.rutland@....com>,
	<matthias.bgg@...il.com>, <robh@...nel.org>, <robin.murphy@....com>
CC:	<p.zabel@...gutronix.de>, <devicetree@...r.kernel.org>,
	<pebolle@...cali.nl>, <kendrick.hsu@...iatek.com>, <arnd@...db.de>,
	<srv_heupstream@...iatek.com>, <catalin.marinas@....com>,
	<will.deacon@....com>, <linux-kernel@...r.kernel.org>,
	<tfiga@...gle.com>, <iommu@...ts.linux-foundation.org>,
	<robh+dt@...nel.org>, <djkurtz@...gle.com>,
	<kernel@...gutronix.de>, <linux-mediatek@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>, <l.stach@...gutronix.de>,
	<yingjoe.chen@...iatek.com>, <eddie.huang@...iatek.com>,
	<youlin.pei@...iatek.com>, <erin.lo@...iatek.com>,
	Honghui Zhang <honghui.zhang@...iatek.com>
Subject: [PATCH] iommu/mediatek: Do not call of_node_put in mtk_iommu_of_xlate

From: Honghui Zhang <honghui.zhang@...iatek.com>

The device_node will be released in of_iommu_configure, it may be double
released if call of_node_put in mtk_iommu_of_xlate.

Signed-off-by: Honghui Zhang <honghui.zhang@...iatek.com>
---
 drivers/iommu/mtk_iommu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index c3043d8..493bd3e 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -455,7 +455,6 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
 	if (!dev->archdata.iommu) {
 		/* Get the m4u device */
 		m4updev = of_find_device_by_node(args->np);
-		of_node_put(args->np);
 		if (WARN_ON(!m4updev))
 			return -EINVAL;
 
-- 
1.8.1.1.dirty