linux-kernel - Re: [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160608110147.GA32077@gmail.com>
Date:	Wed, 8 Jun 2016 13:01:47 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	jacob.jun.pan@...el.com, dave.hansen@...ux.intel.com,
	adrian.hunter@...el.com, ak@...ux.intel.com, luto@...nel.org,
	bp@...en8.de, dvhart@...radead.org, dougthompson@...ssion.com,
	edubezval@...il.com, hpa@...or.com, mingo@...hat.com,
	jacob.jun.pan@...ux.intel.com, kan.liang@...el.com,
	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-edac@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-pm@...r.kernel.org, mchehab@....samsung.com,
	peterz@...radead.org, platform-driver-x86@...r.kernel.org,
	rafael.j.wysocki@...el.com, rajneesh.bhardwaj@...el.com,
	souvik.k.chakravarty@...el.com,
	srinivas.pandruvada@...ux.intel.com, eranian@...gle.com,
	tglx@...utronix.de, tony.luck@...el.com, ulf.hansson@...aro.org,
	viresh.kumar@...aro.org, vishwanath.somayaji@...el.com,
	rui.zhang@...el.com
Subject: Re: [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family
 numbers


* Dave Hansen <dave@...1.net> wrote:

> 
> Changes from v1:
>  * added acks from a few folks
>  * Took the redundant "MODEL_" out of the macro names (Suggested
>    by Borislav Petkov and acked by others)
> 
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> If you are cc'd on this code, please check _your_ code vs. the
> model list in "intel-family.h".  Please make sure you have all
> the models listed that you intend to.
> 
> Also, rather than trickling these in via all the various
> maintainers, should these just get pulled in to the x86 tree in
> one go?
> 
> Problem:
> 
> We have a boatload of open-coded family-6 model numbers.  Half of
> them have these model numbers in hex and the other half in
> decimal.  This makes grepping for them tons of fun, if you were
> to try.
> 
> Solution:
> 
> Consolidate all the magic numbers.  Put all the definitions in
> one header.
> 
> The names here are closely derived from the comments describing
> the models from arch/x86/events/intel/core.c.  We could easily
> make them shorter by doing things like s/SANDYBRIDGE/SNB/, but
> they seemed fine even with the longer versions to me.
> 
> Do not take any of these names too literally, like "DESKTOP"
> or "MOBILE".  These are all colloquial names and not precise
> descriptions of everywhere a given model will show up.
> 
> These have all been compile-tested.  I also made a stab at
> dumping .o files and looking for unexpected deltas when I was
> just replacing magic numbers with equivalent macros.

So I've picked up this series and restructured it: I've created a single patch 
that creates intel-family.h and have put it into x86/urgent. This eliminated 
dependencies and allowed some of the patches to be queued in their natural trees, 
in particular the 7 perf patches.

Thanks,

	Ingo